fix: pass runtime to video service #535
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFlicker
changed the title
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Low
Background
What does this PR do?
This lets me do video service work. Without these changes the video summarization would fail on accessing
runtime.cacheManagerWhat kind of change is this?
Bug fix
Why are we doing this? Any context or related work?
I set up eliza and was getting exception generating videos (luma)
Documentation changes needed?
none
Testing
Where should a reviewer start?
See
video.ts:processVideoFromUrlfunction. This function requires a runtime, thus the runtime is not optional in this implementation of IVideoServiceDetailed testing steps
Discord username
0xflick