chore: remove unused env var #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
approved these changes
Dec 1, 2024
jkbrooks
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Low, because anyone using evm plugin has
EVM_PRIVATE_KEYsetBackground
What does this PR do?
Removes an unused env var
Technically the env var is trivially used to detect whether the evmPlugin should be loaded, but it's not actually used in the plugin itself.
EVM_PRIVATE_KEYwould be better for the checkWhat kind of change is this?
Improvement
Why are we doing this? Any context or related work?
Cleanup
Testing
can
grepfor EVM_PUBLIC_KEY on branch to see no occurrences