-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update package.json
and turbo.json
for improved build and development scripts
#788
Conversation
…evelopment scripts - Changed the 'dev' script in package.json to use 'turbo run dev --parallel --no-cache' for better performance. - Updated turbo.json to streamline task dependencies and outputs for the 'dev' and 'build' tasks. - Modified agent/package.json to point the main entry to 'dist/index.js' and adjusted scripts for building and starting the application. - Enhanced core/package.json 'dev' script to specify the source file for watching during development.
found smth that needs another fix, mb |
Hi @fabianhug, the behaviour of turborepo has been really weird just as you've observed and stated above. The build config and script works as I have previously done. |
perfect - but thanks for frontrunning my contribution, haha! great it works now, nw |
hahahahahahahahahahahahahahahahahahahahahaha I have been on this since Saturday. It was a real pain because I tried getting turborepo to work but it didn't. |
love u bae, closing now |
Relates to:
pnpm run dev does not work out of the box #780
Risks
Medium. While the build system improvements work as expected, the type error in the postgres adapter could affect database operations that rely on embedding configurations. (see next)
Background
What does this PR do?
However, during testing I discovered a type error that needs to be addressed in some future PR:
Module '"@ai16z/eliza"' has no exported member 'getEmbeddingConfig'.
This error appears in
packages/adapter-postgres/src/index.ts
when trying to importgetEmbeddingConfig
from the core package.What kind of change is this?
Improvements (misc. changes to existing features)
Why are we doing this? Any context or related work?
See pnpm run dev does not work out of the box #780
Documentation changes needed?
No
Testing
Where should a reviewer start?
pnpm i
pnpm run dev
Detailed testing steps
packages/adapter-postgres/src/index.ts
Module '"@ai16z/eliza"' has no exported member 'getEmbeddingConfig'
Deploy Notes
The type error in the postgres adapter should be fixed before deploying to prod/new release. The build system changes themselves are ready for deployment.