-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Customize SqlClientFactory with discovery database types #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small request: can you sort the using statements?
Lauryx-star
added a commit
to Lauryx-star/elsa-core
that referenced
this pull request
Mar 23, 2023
* fix typo * update badge * Configuration headers for kafka consumer were not implemented to ConsumerConfig. Implementation provided. (elsa-workflows#3731) Co-authored-by: Recep OBUT <[email protected]> * DeleteMany fixes (elsa-workflows#3718) * Changed so that DeleteAsync uses batch delete and removed psql and mysql work around * Re added mysql workaround * switch to feedz * [no ci] update readme * [no ci] update feedz URL * update feedz npm key * [no ci] update README with feedz * cache npm packages * [no ci] update action version * enable integration tests * Fix credential manager in designer. (elsa-workflows#3739) * Inject `monacoLibPath` in `elsa-credential-manager-items-list` * Fix secret editor in non OAuth2 types. * Adjust so that only finished statuses are also add an OR between status instead of AND (elsa-workflows#3717) * Bump MongoDB.Driver in /src/persistence/Elsa.Persistence.MongoDb (elsa-workflows#3759) Bumps [MongoDB.Driver](https://github.com/mongodb/mongo-csharp-driver) from 2.13.1 to 2.19.0. - [Release notes](https://github.com/mongodb/mongo-csharp-driver/releases) - [Commits](mongodb/mongo-csharp-driver@v2.13.1...v2.19.0) --- updated-dependencies: - dependency-name: MongoDB.Driver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MongoDB.Driver (elsa-workflows#3760) Bumps [MongoDB.Driver](https://github.com/mongodb/mongo-csharp-driver) from 2.13.1 to 2.19.0. - [Release notes](https://github.com/mongodb/mongo-csharp-driver/releases) - [Commits](mongodb/mongo-csharp-driver@v2.13.1...v2.19.0) --- updated-dependencies: - dependency-name: MongoDB.Driver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MongoDB.Driver (elsa-workflows#3761) Bumps [MongoDB.Driver](https://github.com/mongodb/mongo-csharp-driver) from 2.13.1 to 2.19.0. - [Release notes](https://github.com/mongodb/mongo-csharp-driver/releases) - [Commits](mongodb/mongo-csharp-driver@v2.13.1...v2.19.0) --- updated-dependencies: - dependency-name: MongoDB.Driver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Implement Customize SqlClientFactory with discovery database types (elsa-workflows#3781) * Implement Customize SqlClientFactory with discovery database types * Order usings * fix issue elsa-workflows#3744 (elsa-workflows#3788) Co-authored-by: William Verdolini <[email protected]> * Upgrade MediatR to 12.0.1 fixing issue elsa-workflows#3775 (elsa-workflows#3790) * Make copy-pasting work across multiple domains (elsa-workflows#3794) * Make copy-pasting work across multiple domains * Handle errors on paste better --------- Co-authored-by: Tanel Kuhi <[email protected]> * Bump webpack (elsa-workflows#3796) Bumps [webpack](https://github.com/webpack/webpack) from 5.70.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.70.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added general global bookmark provider for all KafkaMessageReceivedOverride Triggers (elsa-workflows#3807) Co-authored-by: Yannick Laubscher <[email protected]> * [no ci] bump preview version * update version of Fody packages (elsa-workflows#3824) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Mohamed Ali <[email protected]> Co-authored-by: Recep Obut <[email protected]> Co-authored-by: Recep OBUT <[email protected]> Co-authored-by: Martin Hjulström <[email protected]> Co-authored-by: Chryssie Ta <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mircotamburini <[email protected]> Co-authored-by: William Verdolini <[email protected]> Co-authored-by: William Verdolini <[email protected]> Co-authored-by: Axel Bergman <[email protected]> Co-authored-by: tanelkuhi <[email protected]> Co-authored-by: Tanel Kuhi <[email protected]> Co-authored-by: Yannick Laubscher <[email protected]> Co-authored-by: Yannick Laubscher <[email protected]> Co-authored-by: Joshua Hartmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i need to implement Sql Activities for AS400.
i add possibilities to pass CustomSqlClientFactory that reference AS400 drivers and automatic discover database types from Activities.