Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: support react-router-dom #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dionjwa
Copy link

@dionjwa dionjwa commented May 4, 2018

Hi. This is a proposal, interested in your feedback.

I'm using react-router-dom:4+. The require imports are slightly different. Do you want to put this on a "version4" branch or similar? I'd rather keep these libs in the same repo, not have personal forks.

@elsassph
Copy link
Owner

elsassph commented May 5, 2018

RR4 has big API changes, but in principle that could be in the same repo as a major update of the same library.

That said, @kLabz has already created another repo for RR4:
https://github.com/kLabz/haxe-react-router

@kLabz
Copy link

kLabz commented May 5, 2018

It could come back here btw if you want to move from RR3 to RR4.

@elsassph
Copy link
Owner

elsassph commented May 5, 2018

I think it makes sense to migrate to RR4, but code splitting has to be approached differently so I need to plan also the samples' migration and tag the RR3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants