Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Add accounts endpoint #226

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Add accounts endpoint #226

merged 1 commit into from
Jan 24, 2020

Conversation

fracek
Copy link
Collaborator

@fracek fracek commented Jan 24, 2020 •
edited
Loading

I had a chat with @abuiles and we agreed not to validate the filtering on client side.

Fix #220

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fracek fracek requested a review from Kirbyrawr January 24, 2020 22:58
Kirbyrawr
Kirbyrawr approved these changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@Kirbyrawr Kirbyrawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@fracek fracek merged commit a3f7dee into elucidsoft:horizon-1.0.0 Jan 24, 2020
@fracek fracek mentioned this pull request Jan 26, 2020
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kirbyrawr Kirbyrawr Kirbyrawr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fracek @Kirbyrawr