Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Rename and redirect OperationFeeStats to FeeStats #267

Conversation

PJvGrol
Copy link
Contributor

@PJvGrol PJvGrol commented Jun 30, 2020

Although #214 mentioned that the operation_fee_stats endpoint would be replaced by fee_stats and marked it as done, the changes required to the requestbuilder seem to have disappeared in #231

As such the OperationFeeStats didn't work. In this PR the oversight is rectified and OperationFeeStats is replaced by FeeStats, and in particular the request builder now properly uses the /fee_stats endpoint.
It will break if trying to use with a Horizon version < 1.0.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PJvGrol PJvGrol force-pushed the rename_operationfeestats_to_feestats branch from 31a5a43 to 92700f5 Compare June 30, 2020 13:43
@elucidsoft elucidsoft requested review from fracek and Kirbyrawr July 1, 2020 22:05
@elucidsoft elucidsoft merged commit 6c1e9ee into elucidsoft:master Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants