Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#148 Schema changes for title actions #149

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

caritaou
Copy link
Member

closes #148

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caritaou caritaou requested a review from matthoward366 July 30, 2024 23:48
Copy link
Member

@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Should we maybe wait to merge until common-properties is updated to make sure nothing else is needed?

@caritaou
Copy link
Member Author

@matthoward366 Yes that sounds good. I'll start coding to these changes and we can merge both together once everything is complete

@caritaou
Copy link
Member Author

caritaou commented Aug 2, 2024

Hi @matthoward366, do we still need to update the form schema? Or are those safe to remove?

@matthoward366
Copy link
Member

It's safe to remove. It was removed in elyra/canvas version 13.

Signed-off-by: Carita Ou <[email protected]>
@caritaou caritaou merged commit 1b4a1b3 into elyra-ai:main Aug 7, 2024
1 check passed
@caritaou caritaou deleted the cou-title-action-schema branch August 7, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema changes for title actions
2 participants