Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix emacs-lsp/lsp-ui#452] Fix markdown link navigation in *lsp-help* buffers #3844

Merged
merged 5 commits into from
Dec 16, 2022

Conversation

vspinu
Copy link
Contributor

@vspinu vspinu commented Dec 10, 2022

Because markdown links are rendered during fontification I couldn't see where to integrate the link lookup except of the generic lsp--fontlock-with-modelsp--fontlock-with-mode

fixes emacs-lsp/lsp-ui#452

@vspinu vspinu force-pushed the fix-markdown-help-link branch from ee6d0b0 to be90e4b Compare December 10, 2022 18:02
@vspinu vspinu changed the title [Fix #452] Fix markdown link navigation in *lsp-help* buffers [Fix emacs-lsp/lsp-ui#452] Fix markdown link navigation in *lsp-help* buffers Dec 10, 2022
@vspinu vspinu force-pushed the fix-markdown-help-link branch from be90e4b to f576d2e Compare December 10, 2022 18:08
lsp-mode.el Outdated Show resolved Hide resolved
  - markdown-link-face, markdown-url-face and markdown-plain-url-face
@vspinu vspinu force-pushed the fix-markdown-help-link branch from 3f4a0f5 to 1cdb46c Compare December 10, 2022 21:52
@yyoncho
Copy link
Member

yyoncho commented Dec 11, 2022

@yyoncho
Copy link
Member

yyoncho commented Dec 11, 2022

In toplevel form:
lsp-mode.el:9399:1:Error: the following functions are not known to be defined: text-property-search-forward, prop-match-beginning, prop-match-end
.....................Test lsp-byte-compilation-test backtrace:

@vspinu
Copy link
Contributor Author

vspinu commented Dec 11, 2022

Rewrote. Hopefully it's good now.

@yyoncho
Copy link
Member

yyoncho commented Dec 13, 2022

Looks good, I will do some manual testing I and will proceed with the merge.

@yyoncho yyoncho merged commit e2a1b5f into emacs-lsp:master Dec 16, 2022
@vspinu vspinu deleted the fix-markdown-help-link branch December 19, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to open hyperlinks in lsp-ui-doc
2 participants