Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for cpp version in lib/util.h - allows using make_unique from standard library in later cpp versions #30

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Add check for cpp version in lib/util.h - allows using make_unique from standard library in later cpp versions #30

merged 2 commits into from
Mar 4, 2022

Conversation

daniel-feldman-ai
Copy link
Contributor

Fixes: #28

Description of Changes

When running with newer CPP versions, we get an error about ambiguous arguments.

Test Plan

TBD!

@daniel-feldman-ai daniel-feldman-ai changed the title add check for cpp version in lib/util.h Add check for cpp version in lib/util.h - allows using make_unique from standard library in later cpp versions Nov 16, 2021
@liambenson liambenson merged commit f8ba583 into embarktrucks:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredjxyz jaredjxyz jaredjxyz approved these changes

@liambenson liambenson liambenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embag doesn't play well with C++14's std::make_unique
3 participants
@daniel-feldman-ai @jaredjxyz @liambenson