Add buffer interface for RosValue arrays #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liambenson
force-pushed
the
liam/add_buffer_interface
branch
from
f7a2739 to
ad0cd71
Compare
jaredjxyz
reviewed
Dec 7, 2021
lib/ros_value.h
Outdated
| @@ -320,6 +323,29 @@ class RosValue { | |||
| return values; | |||
| } | |||
|
|
|||
| // Used for python bindings | |||
There was a problem hiding this comment.
I think very few people are going to be familiar with what pybind11::buffer_info does -
Could you write a better comment explaining what exactly this does and how one might properly use it?
brendangeck
reviewed
Dec 7, 2021
brendangeck
approved these changes
Dec 8, 2021
jaredjxyz
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DATA-516
Description of Changes
This adds a buffer protocol interface to the py bindings for the library.
One minor issue that I have with this is that we're exposing the underlying pointer to the data buffer via the
pybind11::buffer_info, but without writing the interface ourselves rather than using pybind's helpers I'm not sure if theres any alternative.Additionally, requiring that we build the embag library with pybind might not be the best idea, but I think exposing the buffer_info is better than just exposing the raw pointer.
Test Plan
Added a test to ensure that we can create a
memoryviewofarrayRosValues.