stm32 spi rxonly slave #1250
Closed
stm32 spi rxonly slave #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pattop
commented
Mar 1, 2023
pattop
commented
- stm32/spi: fix occasional data corruption
- stm32/spi: add receive only slave
Need to clear the rx fifo before enabling rx dma.
|
SPI slave should be a separate driver, not a mode in the existing driver. (they can share code internally, sure, but the user-facing API has to be different, so we shouldn't squash both APIs into the same struct) |
Dirbaio
reviewed
Mar 1, 2023
| @@ -476,6 +475,7 @@ impl<'d, T: Instance, Tx, Rx> Spi<'d, T, Tx, Rx> { | |||
| let tx_f = crate::dma::write_repeated(&mut self.txdma, tx_request, &clock_byte, clock_byte_count, tx_dst); | |||
|
|
|||
| unsafe { | |||
| set_rxdmaen(T::REGS, true); | |||
There was a problem hiding this comment.
there's some versions where the RM explicitly says you must set RXDMAEN=true, start DMAs, set TXDMAEN=true in that exact order. It was F4 iirc. And indeed if you don't do that it doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.