Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove checks for reserved I2c addresses #3810

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Jan 26, 2025

There are some non-compliant devices that respond to reserved I2c addresses. rp2040 behaves sanely for these addresses, so let's just allow using them.

Closes #3809

There are some non-compliant devices that respond to reserved I2c
addresses. rp2040 behaves sanely for these addresses, so let's just
allow using them.
@Freax13 Freax13 force-pushed the enhancement/invalid-i2c-rp branch from bb65c7c to 3e55146 Compare January 26, 2025 16:43
@Freax13
Copy link
Contributor Author

Freax13 commented Jan 26, 2025

I marked Error::AddressReserved as deprecated. It should be removed in the next breaking release.

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio enabled auto-merge January 26, 2025 16:44
@Dirbaio Dirbaio added this pull request to the merge queue Jan 26, 2025
Merged via the queue into embassy-rs:main with commit 845da2c Jan 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't access non-compliant I2c device
2 participants