[v2] Refactor retrieval #1750
Open
[v2] Refactor retrieval #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
# Conflicts: # mteb/abstasks/AbsTaskRetrieval.py # mteb/models/salesforce_models.py
|
@KennethEnevoldsen @orionw Can you review PR, please? I'll run tasks to compare results |
|
Results for
|
orionw
reviewed
Jan 17, 2025
| @@ -501,49 +512,6 @@ def convert_conv_history_to_query( | |||
| return convert_conv_history_to_query(conversations) # type: ignore | |||
|
|
|||
|
|
|||
| class DRESModel: | |||
There was a problem hiding this comment.
Glad to finally have this removed!
|
Results for
|
# Conflicts: # mteb/models/salesforce_models.py
Samoed
force-pushed
the
refactor_retrieval
branch
from
170b5e9 to
e1f6fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Run tests locally to make sure nothing is broken using
make test.Run the formatter to format the code using
make lint.Removed
DRESModelRemoved work with files in
HFDataLoaderand left only HF repo