Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default use of component throws error #8

Closed
ksin opened this issue May 30, 2017 · 4 comments
Closed

Default use of component throws error #8

ksin opened this issue May 30, 2017 · 4 comments
Assignees
@MelSumner
Labels
help wanted

Comments

@ksin
Copy link

ksin commented May 30, 2017

Using the component with nothing passed in throws an error:
https://github.com/MelSumner/ember-a11y-landmarks/blob/master/addon/components/a11y-landmark.js#L86

That seems weird for ease-of-usage to me. Shouldn't it be a 'div' with role 'region' by default?
@MelSumner
Copy link
Member

@ksin it used to, so I need to see what changed to disallow it.

@MelSumner
Copy link
Member

@EndangeredMassa would you have time to look into this?

@EndangeredMassa
Copy link
Contributor

EndangeredMassa commented Jul 6, 2017 •
edited
Loading

It did indeed, but in my refactoring that was removed.

@MelSumner: Do we want that to be the default? We can definitely change it.

@EndangeredMassa EndangeredMassa mentioned this issue Jul 17, 2017
Closed
@kmillns kmillns mentioned this issue Nov 8, 2017
Merged
@EndangeredMassa
Copy link
Contributor

Resolved by: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MelSumner MelSumner

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EndangeredMassa @MelSumner @ksin