Integration tests #9
Conversation
assert.throws has some deprecations in 2.12+
| run(() => { set(this, 'tagName', landmark); }); | ||
|
|
||
| this.render(hbs` | ||
| {{#a11y-landmark tagName=tagName}} |
There was a problem hiding this comment.
I don't have the time to dig more into this right now but the Travis builds for the older LTS versions seem to be failing because of this. Apparently, setting the component's tagName params to a variable sends in an [Object object] (haven't figured out what that looks like yet). Using a literal string like tagName="nav" seems to work fine.
Would love to know what's wrong / what the fix is if someone knows. :)
|
@ksin did you want to rebase and work through this a little more so we can merge? |
|
I pushed a new branch for reference where I fixed the merge conflict and fixed #8 Branch: https://github.com/ember-a11y/ember-a11y-landmarks/commits/ksin-add-tests Do you want to use this to update your PR, @ksin? |
|
@MelSumner @EndangeredMassa hey! sorry I've been a little caught up with stuff lately. I'll circle back in a week or so. thanks for the ping reminders :) |
|
Closing this due to age and being outdated. If you want to open a new PR, feel free! Thanks! |
ember-qunit-assert-helpersinstead of usingassert.throwsbecause assert.throws fails in component integration tests with ember 2.12 emberjs/ember-qunit#256.Was too much hassle to rebase #3, so started a new branch. :)