Canary expects services to be a subclass of Ember.Service #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef4
added a commit
that referenced
this pull request
May 25, 2015
Canary expects services to be a subclass of Ember.Service
|
Thanks! |
|
Thanks for this! It was biting me this morning |
|
can we have a release please ? |
|
I just upgraded to canary myself, and it would be good if this got released - liquid breaks my app if this fix is not added. For now: |
|
On canary this check is now a deprecation instead of an assert, so updating canary will also fix your app until a new version if liquid-fire is cut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails in canary