[BUGFIX] if our ancestor import declaration is removed short-circuit … #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
commented
Jun 19, 2019
| @@ -58,8 +58,13 @@ module.exports = class Macros { | |||
| if (!this.debugHelpers.module) { | |||
| if (this.localDebugBindings.length > 0) { | |||
| let importPath = this.localDebugBindings[0].findParent(p => p.isImportDeclaration()); | |||
| if (importPath === null) { | |||
| // import declaration in question seems to have already been removed | |||
There was a problem hiding this comment.
I noticed this in the wild, my guess is two babel plugins are both mutating the graph. Resulting in this outcome...
There was a problem hiding this comment.
Might be related to emberjs/ember-cli-babel#286 (comment)
There was a problem hiding this comment.
FWIW, those two babel plugins both operate on separate import paths.
There was a problem hiding this comment.
stefanpenner
force-pushed
the
short-circuit
branch
from
789ab55 to
a8a69d0
Compare
|
@rwjblue ya, trying to come up with one that is representative. Although I'm not 100% sure my above idea is the root cause. |
5 tasks
stefanpenner
force-pushed
the
short-circuit
branch
from
a8a69d0 to
3358c58
Compare
rwjblue
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gracefully