This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Tests for type information #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-north
commented
Mar 22, 2019
addon/utils/ajax.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import jQuery from 'jquery'; | |||
| import * as jQuery from 'jquery'; | |||
There was a problem hiding this comment.
This does type information consumers a favor by allowing ember-ajax to work without forcing them to turn on allowSyntheticDefaultImports or esModuleInterop flags in their tsconfig.json. Libraries should generally not enable these flags for this reason
There was a problem hiding this comment.
Looks like we may need to resolve this in a separate PR because babel doesn't like the wildcard import (worth noting that tsc would compile this correctly)
mike-north
force-pushed
the
ts-tests
branch
6 times, most recently
from
947b54a to
bcc97da
Compare
mike-north
commented
Mar 22, 2019
| "strictNullChecks": true, | ||
| "strictFunctionTypes": true, | ||
| "noEmit": true, | ||
| "allowSyntheticDefaultImports": true, |
There was a problem hiding this comment.
This indicates that all consumers also need this flag. More info here: #441 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into some problems where type information was in misalignment with documentation (i.e., #440)
This PR sets up infrastructure for testing type information using dtslint.
Some fixes were needed in types for the library itself, but they all seem like improvements