This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
don't cover open Module drop-down #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `#ember-testing-container` has a z-index of 9999, which I'm guessing is random. However, the Module dropdown in the Qunit header has a z-index of 99, so when passed tests are hidden and all tests pass, the `#ember-testing-container` covers the dropdown without this fix. See https://monosnap.com/file/ouYQKdxc1mMzMpStK9SCp3iUnN6eLQ. I changed `.full-screen` just for consistency, though it works properly either way.
rwjblue
approved these changes
Apr 21, 2017
trentmwillis
approved these changes
Apr 22, 2017
|
Thanks @trentmwillis - such a pleasure to help, and to get this fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
#ember-testing-containerhas a z-index of 9999, which I'm guessing is random. However, the Module dropdown in the Qunit header has a z-index of 99, so when passed tests are hidden and all tests pass, the#ember-testing-containercovers the dropdown without this fix. See https://monosnap.com/file/ouYQKdxc1mMzMpStK9SCp3iUnN6eLQ. I changed.full-screenjust for consistency, though it works properly either way.