[ENHANCEMENT] Vanilla Prettier setup in blueprints [RFC 1055]

[bertdeblock]

No description provided.

[ef4]

Suggested alternative: can we put **/*.html in the prettierignore?

Because the formatting prettier is producing here is not great. You were forced to add the special prettier-ignore comment line. And prettier is making several tags self-closing that are not actually supposed to be self-closing in the HTML spec.

The current blueprint doesn't do prettier formatting for html, so this is not a loss of existing functionality.

Separate question: is this introducing prettier formatting to markdown, and if so does it also rewrite people's READMEs? If so, that would possibly be another extension to ignore.

[bertdeblock]

I'm now slightly worried that my RFC wasn't clear enough.
The intention was to format all files Prettier supports, including (but not limited to) *.html and *.md files.

Functionally, the ignore comments are not needed and I can remove them.
I understand the issue about self-closing void tags, but that would also happen in *.hbs, *.gjs and *.gts files (e.g. <input> => <input />).
If we would ignore those extensions as well, than a large portion of a project would go unformatted, which would go against the intention of the RFC.

[NullVoxPopuli]

hbs / gjs / etc are not explicitly HTML tho -- and this goes for jsx, vue, svelte, ng / angular, it's all shorthand to (eventually) generate HTML.

the HTML file is the only real HTML we have.

[mansona]

apparently there is a plugin that fixes the issue? prettier/prettier#15336 (comment)

[bertdeblock]

I'm only saying that formatting-wise the same issue occurs in hbs, gjs, ...

[bertdeblock]

Indeed, but I didn't really want to include yet another dependency in the blueprint. I would prefer to just follow Prettier. To me, that's kind of the point of using Prettier. Let it decide what's best readability/formatting wise.

[mansona]

I agree with the point of prettier (I may not like it but I agree with what it's trying to do)... but in this case it's just wrong 🤔 Void elements are not and should not be "self closing"

[mansona]

https://html.spec.whatwg.org/multipage/syntax.html#start-tags

Then, if the element is one of the void elements, or if the element is a foreign element, then there may be a single U+002F SOLIDUS character (/), which on foreign elements marks the start tag as self-closing. On void elements, it does not mark the start tag as self-closing but instead is unnecessary and has no effect of any kind. For such void elements, it should be used only with caution — especially since, if directly preceded by an unquoted attribute value, it becomes part of the attribute value rather than being discarded by the parser.

[SergeAstapov]

if another vote matters, I agree with @mansona that Prettier is surely wrong and ignorant for that issue (the reason is most likely because of React and JSX, like this reddit thread suggest https://www.reddit.com/r/reactjs/comments/jc8964/self_closing_tags_in_react/)

Hence, my vote goes to doing right thing and either ignore .html files (but do format .hbs, .gts, .gjs, etc.) or use Prettier plugin (only if it works perfectly).

[bertdeblock]

fwiw, I'm not arguing that Prettier is doing the right thing. I agree that it's not according to the spec. I just feel that's a discussion for the Prettier project.

[SergeAstapov]

maybe we should do RFC amendment to clarify this in RFC rather than in this thread? just a thought

[bertdeblock]

Yeah, maybe it's safer to ignore html files for now then. Most projects only have 2 anyways.

[ef4]

I'm now slightly worried that my RFC wasn't clear enough.
The intention was to format all files Prettier supports, including (but not limited to) *.html and *.md files.

Looking at the RFC I think your intent is clear, but speaking for myself the thing I was paying attention to in the RFC is stopping running prettier inside eslint. That is, IMO, the most important motivation. Having the option of running prettier on more file types is only one of the benefits of that decision, and not nearly the most important one.

(Having prettier inside eslint is miserable. I've seen way too many developers reacting to red squiggles from the prettier eslint plugin, which is defeats the point of having prettier, which should free you to stop paying attention to formatting).

[bertdeblock]

HTML changes are reverted, and *.html is added to the Prettier ignore file.
Ready for another review I think!