fix: Fastboot title updates with nested slow model() routes #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged we should roll out v6.1.0 - as we have removed EmberArray etc. dependencies, so there have been quite few changes, more than patch version would justify in my opinion. |
raido
force-pushed
the
bugfix-fastboot-title
branch
from
13071bd to
6286ed2
Compare
raido
force-pushed
the
bugfix-fastboot-title
branch
from
6286ed2 to
379b6bd
Compare
|
I cleaned up few things and good for review. |
|
I'd disagree about the minor bump, since there were no new features. It has all been internal changes. Are you concerned about a breaking change? |
knownasilya
reviewed
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure we always render one
titleelement during Fastboot render.Unfortunately it is not possible to acceptance test this, because there's is no way to test handover from "fastboot -> client side".
Closes: #195