Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test for Fastboot multiple title elements #197

Merged

Conversation

raido
Copy link
Contributor

@raido raido commented Oct 17, 2020

This PR adds test coverage for PR #196.

@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<head>
<title>Ember Page Title</title>
<title data-test-ignore-for-fastboot-tests>Ember Page Title</title>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are keeping original title element for non-fastboot vs fastboot tests - we need to filter it out for assertions.

@raido raido requested a review from knownasilya October 17, 2020 05:54
@knownasilya knownasilya merged commit 4fa6ea8 into ember-cli:master Oct 17, 2020
@knownasilya
Copy link
Contributor

Nice!

@raido raido deleted the test-for-multiple-titles-fastboot branch October 19, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants