Setup Prettier with ESLint integration #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemarluedke
commented
Jul 7, 2018
| "eslint-plugin-ember": "^5.0.0", | ||
| "eslint-plugin-node": "^6.0.1", | ||
| "loader.js": "^4.2.3" | ||
| "eslint-plugin-prettier": "2.6.0", |
There was a problem hiding this comment.
This dependency's version is fixed because of this problem: ember-cli/ember-cli-eslint#235
Once that is fixed, we should be able to relax the version required.
josemarluedke
force-pushed
the
add-prettier
branch
from
aa6728d to
a23aaea
Compare
josemarluedke
force-pushed
the
add-prettier
branch
from
a23aaea to
31c305e
Compare
|
@josemarluedke awesome, I put this off way too long 😬 thank you! ✌️ |
|
@josemarluedke btw feel free to add yourself to the readme contributors list in your next PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for suggestions if this is not desired, but I personally find it very useful to have a project with Prettier configured with ESLint integration.
It seems some code has the comma dangle option enabled, I'm happy to add that into the prettier config and rerun the fixes.I have added the trailingComma option and fixed all the code around this config.