Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a deprecations writing guide #118

Merged
merged 7 commits into from
Jul 15, 2019
Merged

create a deprecations writing guide #118

merged 7 commits into from
Jul 15, 2019

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Jun 6, 2019

I just learned how to do this! I would love feedback on anything that is missing or could be explained better.

guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Show resolved Hide resolved
guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Outdated Show resolved Hide resolved
guides/writing-addons/deprecations.md Show resolved Hide resolved
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @jenweber!

@MelSumner
Copy link
Member

@jenweber looks like there's an alex issue:
"48:119-48:124 warning Be careful with “fires”, it’s profane in some cases fires retext-profanities"

@mansona mansona merged commit 70583eb into master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the deprecations branch July 15, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants