Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Edit this page' link regex #237

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Update 'Edit this page' link regex #237

merged 2 commits into from
Sep 5, 2018

Conversation

22a
Copy link
Contributor

@22a 22a commented Sep 4, 2018

This PR updates the Edit this page link filter regex from

  • template.+(hbs|md)
    to
  • \.(hbs|md)$

this removes the necessity to have the string "template" in doc filenames, in turn preventing dead links such as https://github.com/user/repo/edit/branch/undefined

I'm not too concerned about the trailing $ if it's not agreeable but happy to discuss.

@dfreeman
Copy link
Contributor

dfreeman commented Sep 4, 2018

Thanks @22a! This seems reasonable to me, but @samselikoff should probably confirm. I wonder if there's a lightweight way to include test coverage for this so we don't regress in the future?

@samselikoff
Copy link
Contributor

Even a hard-coded test for a currently existing docs page would be great

@22a
Copy link
Contributor Author

22a commented Sep 4, 2018

@dfreeman @samselikoff Good point, added!

@samselikoff samselikoff merged commit f9ded5c into ember-learn:master Sep 5, 2018
@samselikoff
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants