Add prompt for ESDoc/YUIDoc #248
Conversation
This adds a prompt so you can select ESDoc or YUIDoc when the blueprints run.
| @@ -63,9 +63,39 @@ module.exports = { | |||
| } | |||
|
|
|||
| if (!hasPlugins) { | |||
| return this._chooseAddonsToInstall() | |||
There was a problem hiding this comment.
Looks like there's a lint failure because the return below this one is dead code now
There was a problem hiding this comment.
Good call, I meant to remove that.
| return this.addAddonsToProject({ | ||
| packages: [addon], | ||
| blueprintOptions: { | ||
| save: options.save |
There was a problem hiding this comment.
What is this option doing? Was something behaving wrong when we didn't have it before?
There was a problem hiding this comment.
This just allows a passthrough of if you do ember install ember-cli-addon-docs --save it passes the --save to the other deps it adds here.
| return this.ui.prompt({ | ||
| type: 'list', | ||
| name: 'addonToInstall', | ||
| message: 'Which documentation style would you like to use?', |
There was a problem hiding this comment.
Should we include a choice not to install anything at all? I could imagine wanting to use another addon-docs plugin that isn't necessarily part of the ember-learn org, or just not needing or wanting generated API docs for an addon at all.
There was a problem hiding this comment.
I think we could certainly add options, as they become necessary. I think for now, this is an improvement on always using yuidoc.
There was a problem hiding this comment.
Fair enough. I'll probably turn around and add a "no plugin" option anyway because I think it's valuable, but I don't need to push that work on you here 🙂
This adds a prompt so you can select ESDoc or YUIDoc when the blueprints run.