Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tough-cookie to support Node 6 #302

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Pin tough-cookie to support Node 6 #302

merged 1 commit into from
Jan 21, 2019

Conversation

samselikoff
Copy link
Contributor

@samselikoff samselikoff commented Jan 21, 2019

Should be ablve to remove this if/when salesforce/tough-cookie#141 is merged.

Fixes #298

Should be ablve to remove this if/when salesforce/tough-cookie#141 is merged.
@samselikoff
Copy link
Contributor Author

Lots of good code in the migrator script and it only adds one dep (jsdom) to our package.json. Seems like we should keep it around if possible. Also Node 6 being EOL'd in April & that PR on touch-cookie hopefully being merged means this resolutions hack can be removed soon...

Thoughts?

@pzuraq
Copy link
Contributor

pzuraq commented Jan 21, 2019

👍 on this if it fixes the issues we're seeing

@samselikoff
Copy link
Contributor Author

Believe it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants