Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #274

Merged
merged 5 commits into from
Jan 30, 2020
Merged

Minor improvements #274

merged 5 commits into from
Jan 30, 2020

Conversation

mansona
Copy link
Member

@mansona mansona commented Jan 23, 2020

Fixes #272

@mansona mansona changed the base branch from master to website-redesign-rfc January 23, 2020 10:04
@mansona mansona force-pushed the minor-improvements branch from 379c398 to ad4776e Compare January 23, 2020 10:04
@mansona mansona requested a review from a team January 23, 2020 10:05
@mansona
Copy link
Member Author

mansona commented Jan 23, 2020

This is safe to merge, CI is failing on ember-beta and ember-canary because of emberjs/ember.js#18693

MelSumner
MelSumner approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have increased the number of wrapping div elements, definitely going to need to address this later. Thanks for working on this!

@mansona
Copy link
Member Author

mansona commented Jan 30, 2020

I'm merging this without Travis passing. It's just ember-beta failing because of emberjs/ember.js#18693

@mansona mansona merged commit 6c7a696 into website-redesign-rfc Jan 30, 2020
@mansona mansona deleted the minor-improvements branch January 30, 2020 08:04
@mansona mansona mentioned this pull request Jan 30, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansona @MelSumner