Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCTANE] Editing Pass #672

Merged
merged 5 commits into from
Mar 27, 2019
Merged

[OCTANE] Editing Pass #672

merged 5 commits into from
Mar 27, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Mar 18, 2019

Quick pass, updating and fixing up a few things that have changed.

@pzuraq pzuraq requested review from jenweber and mixonic March 18, 2019 23:27
Copy link
Contributor

@mike-north mike-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for finding replacement terminology for "bind"!

@MelSumner MelSumner changed the title [OCTANE] Editting Pass [OCTANE] Editing Pass Mar 19, 2019
@attr image;
@attr bedrooms;
@attr description;
@attr() title;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jenweber jenweber merged commit 7d35c2d into octane Mar 27, 2019
@jenweber
Copy link
Contributor

Thank you! Let me know if this merits some spinoff issues to account for the content in the removed files.

@pzuraq pzuraq deleted the editting-pass/octane branch March 27, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants