Remove this.setupRouter from tests
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is released in 3.25.1, 3.24.2 emberjs/ember.js#19387 (comment) |
chancancode
reviewed
Feb 10, 2021
|
|
||
| > Zoey says... | ||
| > | ||
| > As its name implies, the `beforeEach` hook runs *once* before each `test` function is executed. This hook is the ideal place to set up anything that might be needed by all test cases in the file. On the other hand, if you need to do any cleanup after your tests, there is an `afterEach` hook! |
There was a problem hiding this comment.
Do we need to move this somewhere else? Do we use beforeEach elsewhere?
There was a problem hiding this comment.
Good catch! It is indeed taught on this page. I've added it back
|
hmm the test is still failing, I'm looking into the regression |
This is no longer needed when emberjs/ember.js#19326 lands
|
@chancancode this is passing on new releases |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)