WIP A11y updates #87
WIP A11y updates #87
Conversation
simpler input remove console.logs remove another console log fix role for options couple of more improvements
…ithub.com/toddjordan/super-rentals into toddjordan-global-accessibility-awareness-day
|
My PR styling: Old PR styling: |
| @@ -1,6 +1,6 @@ | |||
| <article class="listing"> | |||
| <a {{action 'toggleImageSize'}} class="image {{if isWide "wide"}}"> | |||
| <img src="{{rental.image}}" alt=""> | |||
| <a {{action 'toggleImageSize'}} class="image {{if isWide "wide"}}" aria-hidden="true" tabindex="-1"> | |||
There was a problem hiding this comment.
- Interactive elements are not supposed to be hidden- can you tell me what the purpose would be here?
- Also, if you were to hide an element, you wouldn't need an alt attribute value on a child element.
There was a problem hiding this comment.
It was overlooked during copy & paste. I'll fix this and then get started on any edits to the tutorial
There was a problem hiding this comment.
Alright, a few of things before merging this one. First, I resolved conflicts, but then had to fix a couple of things. I pr'd those updates to your branch: https://github.com/jenweber/super-rentals/pull/1
Second, the changes you made to the css files need to go back into tutorial styles addon. I see you made a pr so I will take care of that.
Third, we need to update the tutorial. Its all you if you have bandwidth. Otherwise I can take it on.
|
@jenweber The travis errors will go away once https://github.com/jenweber/super-rentals/pull/1 is merged |
|
closing this one in favor of #121 (conflict resolutions, test fixes) |
WIP: once this PR is approved, I'll do the work in the tutorials app. Once both repos have PRs, they can be merged
Addresses #86. This PR reworks some of the changes made in #26
I have addressed the CSS errors. Todd, I reverted some of the work on roles because I couldn't resolve the warnings. I think certain role elements should be direct children/siblings and this app doesn't work that way right now. I'd rather show a simpler implementation that introduces a11y concerns but doesn't confuse new devs.
CSS changes are as slight as possible to possibly avoid redoing every single screenshot. Opinions on whether it's close enough?
cc @toddjordan @MelSumner