Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add June Learning Team agenda #306

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Add June Learning Team agenda #306

merged 9 commits into from
Jun 10, 2020

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented May 22, 2020

No description provided.

@chriskrycho
Copy link
Contributor

chriskrycho commented May 22, 2020

I’m planning to attend, and would love to put this on the agenda:

### replacing `ember-ref-modifier` (CK)

One of the advanced examples in the guides, [Communicating Between Elements in
a Component][example], uses `ember-ref-modifier` to show how to implement some
custom functionality. This example dates to a time before the existence of
`ember-modifier`, and was reasonable to include at the time. However, today the
example can be implemented much more cleanly using a class-based modifier from
`ember-modifier`. Just as importantly, using `ref` has significant performance
implications that are *not* obvious: it requires two rendering passes. I’ve had
to wave people off of using `ref` a couple times already in our app as we adopt
Octane, because it’s officially recommended in the Guides, which we point people
to as our *first* source of truth for how to write Octane. I suggest we remove
it in favor of another example using one of the `ember-modifier` variants.

[example]: https://guides.emberjs.com/release/components/template-lifecycle-dom-and-modifiers/#toc_communicating-between-elements-in-a-component

@rwjblue
Copy link
Member

rwjblue commented May 22, 2020

FWIW, I share @chriskrycho's opinion / concern.

@jrjohnson
Copy link

jrjohnson commented May 22, 2020

Yes please! As it was suggested in the guides we used it in our Octane migration and have been unpleasantly surprised by race conditions several times. Though my alternative proposal is to make it work more with less surprises

@amyrlam amyrlam requested a review from a team May 23, 2020 03:12
@chriskrycho
Copy link
Contributor

chriskrycho commented May 23, 2020

Yeah, that would also be a possible win! As I'll elaborate in the meeting, even without those particular performance surprises I think using ember-modifier and properly encapsulating the interesting bits is likely always going to be the better move, though. 😅

@lifeart
Copy link

lifeart commented May 24, 2020

For note: If it will be replaced, we need to add note about - “dom” property can’t be tracked, because of emberjs/ember.js#18698

Currently modifiers logic running on the end of rendering in same transaction, and if tracked property have been accessed before setting it, it will throw error.

There is a case to detect is property tracked or note, but I’m not going forward with it because there is no feedback lifeart/ember-ref-modifier#232 (comment)

Original ref modifier implementation worked without scheduling, but this behavior siding on mentioned cases.

Between performance and stability I choose stability (for novice users), and if use cases has strong perf degradation - it’s really preferable to not use ember-ref-modifier.

Discussion - lifeart/ember-ref-modifier#203

Anyway I'm open to any suggestions, and if there is agreed concern about changes inside ref-modifier or eliminating it from official documentation - I'm with you.

I understand that this repo is not the case for single-person decision making, and I'm also open to transfer it to any organization (if needed).

@mehulkar
Copy link

mehulkar commented May 28, 2020

leaving initials blank as i'm not sure i can actually be at the meeting, but would still like to nudge the team forward into thinking about it and giving the community an update.

### Ember CLI API docs (?? - 10mins)

I want to get an update on getting API docs on `https://api.emberjs.com/ember-cli`
and redirecting `ember-cli.com/api`. As embroider approaches and the larger
JS community experiments with JS development (e.g. Snowpack), it is
important for the Ember project to _enable_ its community to experiment also.
Moving the API docs to the main site will make it easier to improve
documentation, add examples, and propose API improvements that can
enable such experimentation.

@amyrlam
Copy link
Member Author

amyrlam commented Jun 3, 2020

Copied the topics in. Please use GitHub suggestions if any adds/edits!

@amyrlam
Copy link
Member Author

amyrlam commented Jun 4, 2020

@chriskrycho @rwjblue @jrjohnson @lifeart @mehulkar @ijlee2 in case you're attending, it sounds like we may be meeting on Discord voice channel (not sure what it entails yet! but is different from the link on the calendar invite), so please check out #dev-ember-learning on Discord tmrw

@amyrlam amyrlam requested review from locks and ijlee2 June 9, 2020 17:14
@locks locks merged commit 6f89b34 into master Jun 10, 2020
@locks locks deleted the amy/add-next-agenda branch June 10, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants