Fix tests on canary. They broke when Ember.js removed the meta.descs #2756
Conversation
bmac
force-pushed
the
fix-canary-tests
branch
from
2a35e00 to
7129853
Compare
|
I'm not sure why the relationship integration tests are complaining about "run loop at end of test". They all are green for me locally in both the browser and the command line. I will investigate some more tonight. |
|
This has happened for me locally, running it again usually solves it. No idea why it's happening though. Force push? |
|
I've also hit this sporadic "run loop at end of test" error locally as well. But that doesn't seem to be the issue here as I've re-triggered the build several times and it seems to consistently be failing at the same spot on travis. |
bmac
force-pushed
the
fix-canary-tests
branch
15 times, most recently
from
bd5af31 to
374a58f
Compare
| @@ -7,6 +7,10 @@ var hasMany = DS.hasMany; | |||
| var belongsTo = DS.belongsTo; | |||
| var hash = Ember.RSVP.hash; | |||
|
|
|||
| function getComputedPropertyDesc(model, key) { | |||
| return Ember.meta(model).descs ? Ember.meta(model).descs[key] : model[key]; | |||
There was a problem hiding this comment.
the check needs to be a bit more specific, as this may grab non descs out of the object aswell.
cc @ebryn I know this is violating a private API, but it is working around some annoying cross version issues and a serious performance hack. The proper solution is a hefty refactor that will happen sometime soon. Hence the triage fix.
There was a problem hiding this comment.
@stefanpenner what should I test for to be more specific?
There was a problem hiding this comment.
bmac
force-pushed
the
fix-canary-tests
branch
9 times, most recently
from
7d5b06c to
751566c
Compare
bmac
force-pushed
the
fix-canary-tests
branch
10 times, most recently
from
5a652f3 to
7fa7fde
Compare
|
I've spent a few hours on this pr today and Thursday attempting to try down why travis is reporting a "run loop at end of test" in canary and I haven't made much progress. If any one has any theories or insight I'm all ears. |
|
Cleared the cache on travis and now everything is green. |
| @@ -7,6 +7,15 @@ var hasMany = DS.hasMany; | |||
| var belongsTo = DS.belongsTo; | |||
| var hash = Ember.RSVP.hash; | |||
|
|
|||
| function getComputedPropertyDesc(model, key) { | |||
There was a problem hiding this comment.
Can you add a comment here why we need to do this.
bmac
force-pushed
the
fix-canary-tests
branch
from
e7ff15a to
54286d5
Compare
Fix tests on canary. They broke when Ember.js removed the meta.descs
property.
See emberjs/ember.js#10323
cc @ebryn @igorT