Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Ember.K to legacy addon #5

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Moving Ember.K to legacy addon #5

merged 1 commit into from
Nov 30, 2017

Conversation

thoov
Copy link
Member

@thoov thoov commented Nov 29, 2017

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small points:

  • Can you call _super in included?
  • Add tests like how folks use Ember.K "in the wild"? I'm thinking of something like:
test('asdf', function(assert) {
  let Thing = Ember.Object.extend({
    randomMethod: Ember.K,
  });
  let instance = Thing.create();
  assert.strictEqual(instance.randomMethod(), instance);
});
  • Add back the deprecation (e.g. access Ember.K should still issue a deprecation).

@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2017

Also, I just enabled CI here so the next rebase should kick off a build...

@thoov thoov force-pushed the ember-k branch 2 times, most recently from b598b50 to a5ca75c Compare November 30, 2017 18:55
@thoov
Copy link
Member Author

thoov commented Nov 30, 2017

@rwjblue Addressed the feedback. Can you retrigger the builds as this is running into the stupid travis-ci build bug right now?

@rwjblue rwjblue merged commit 6701e0f into emberjs:master Nov 30, 2017
@thoov thoov deleted the ember-k branch December 1, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants