Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class decorator woes with 7.26.7 #423

Closed
jherdman opened this issue Dec 15, 2021 · 4 comments
Closed

Class decorator woes with 7.26.7 #423

jherdman opened this issue Dec 15, 2021 · 4 comments

Comments

@jherdman
Copy link

jherdman commented Dec 15, 2021

Since updating to ecli-babel 7.26.7 I see the following error:

Decorating class property failed. Please ensure that proposal-class-properties is enabled and runs after the decorators transform

This is reproduced with the following app: https://github.com/jherdman/hump-day-sadness

Edit: updated the version number 🤭

@vst
Copy link

vst commented Dec 15, 2021

Same here. I had to pin down the dependency to v7.26.6.

PS: I think that you meant v7.26.7.

Update: Pinning to v7.26.6 did not work in our application. v7.26.7 gets installed too somehow when regenerating yarn.lock (weird), and in return, this breaks the application.

@jherdman jherdman changed the title Class decorator woes with 3.26.7 Class decorator woes with 7.26.7 Dec 16, 2021
@NullVoxPopuli
Copy link
Contributor

Whoops, i made a duplicate #425

@dknutsen
Copy link

@vst you can use a yarn resolution to force 7.26.6 temporarily

@chriskrycho
Copy link
Contributor

Working on a fix in #426. Will update there as we make progress. (Turns out we didn't have test coverage for this! That's the first thing I'm doing: adding coverage.)

chriskrycho added a commit to chriskrycho/ember-cli-babel that referenced this issue Dec 16, 2021
chriskrycho added a commit to chriskrycho/ember-cli-babel that referenced this issue Dec 16, 2021
chriskrycho added a commit to chriskrycho/ember-cli-babel that referenced this issue Dec 16, 2021
rwjblue pushed a commit to chriskrycho/ember-cli-babel that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants