-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt builtin components #1
Conversation
We don't need to re-export the components in the app folder. We only want the components to be importable from the addon, but we don't want them to be automatically resolvable under those names, otherwise they will shadow the ones from ember. |
@chancancode I have removed the re-exports now, thanks for the quick feedback on that. I did want to confirm that it's the I have run into a few imports that I believe are private or otherwise not exported from their source package, such as these from the link-to component. Do you have any recommendation on how I might proceed with handling those? I could always PR the packages to export them if needed but I'm guessing that's not desirable or where possible we could look at porting the related thing into this addon as well but that's likely not possible for some of these... // private in link-to
import RouterState from '@ember/-internals/routing/lib/system/router_state';
import { isSimpleClick } from '@ember/-internals/views';
import { flaggedInstrument } from '@ember/instrumentation';
import { HAS_BLOCK } from '../component-managers/curly';
// private in text-field
import { hasDOM } from '@ember/-internals/browser-environment'; |
7892463
to
a0171d9
Compare
I've landed a CI suite for this addon which tests against Ember 3.28.x stable, and against a build of the branch emberjs/ember.js#19806. |
a0171d9
to
15c0745
Compare
da7d7d4
to
d9d0224
Compare
Ok. There is a CI build, and it is green. What have we done:
I'm not sure we're done with this work, but I'm inclined to merge this PR and encourage others to help close the gap working against @chancancode @jamemackson @rwjblue what do you think? |
Let's do it. Thank you @jamemackson for getting this going! |
description
in support of RFC 0671, this PR aims to move the checkbox, textarea, text-field, and link-to components into this addon.