Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Chai helpers for custom assertions #27

Merged
merged 1 commit into from
Mar 25, 2015
Merged

Expose Chai helpers for custom assertions #27

merged 1 commit into from
Mar 25, 2015

Conversation

dfreeman
Copy link
Contributor

Chai exposes some utilities for creating plugins, e.g. for defining custom assertions. This change just propagates that exposure through the module shim.

@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2015

The build failures are due to the bug fixed in emberjs/ember-test-helpers#28. We need to update ember-test-helpers to 0.4.1 for ember-mocha (should likely be another pull request though).

@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2015

OK, #29 is merged, can you rebase to get this to pass?

@dfreeman
Copy link
Contributor Author

All set -- thanks for getting to #29 so quickly :)

dgeb added a commit that referenced this pull request Mar 25, 2015
Expose Chai helpers for custom assertions
@dgeb dgeb merged commit 3a53bbc into emberjs:master Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants