Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Ember 2.0.0 beta 3 #80

Closed
ghost opened this issue Jul 20, 2015 · 7 comments
Closed

Does not work with Ember 2.0.0 beta 3 #80

ghost opened this issue Jul 20, 2015 · 7 comments

Comments

@ghost
Copy link

ghost commented Jul 20, 2015

  • It uses Ember.View, which is (soft-)removed since beta.3
  • Tests need ember-data#canary because ember-data < 2 uses ArrayPolyfills

I'm cooking up a PR to fix this. Help is definitely welcome.

@ghost
Copy link
Author

ghost commented Jul 20, 2015

ContainerView uses {{view}}, see emberjs/ember.js#11818

@rwjblue
Copy link
Member

rwjblue commented Jul 20, 2015

#79 fixes some of this. But I'm still figuring out how to remove container view usage.

@ghost
Copy link
Author

ghost commented Jul 20, 2015

This might be naive but this is what fixes it for me:

     this.callbacks.render = function() {
-      var containerView = Ember.ContainerView.create({container: container});
+      var subject;
       Ember.run(function(){
-        var subject = context.subject();
-        containerView.pushObject(subject);
-        containerView.appendTo('#ember-testing');
+        subject = context.subject();
+        subject.appendTo('#ember-testing');
       });

       _this.teardownSteps.unshift(function() {
         Ember.run(function() {
-          Ember.tryInvoke(containerView, 'destroy');
+          Ember.tryInvoke(subject, 'destroy');
         });
       });
     };

@ghost
Copy link
Author

ghost commented Jul 20, 2015

#79, #81, #82, and #83 together should fix all problems.
Except I can't figure out how to use an older version of ED with ember-try in the 1.11 scenario.

@rwjblue
Copy link
Member

rwjblue commented Jul 20, 2015

I can't figure out how to use an older version of ED with ember-try in the 1.11 scenario.

We can't. ember-try only allows configuration of dependencies, not devDependencies. This could probably be fixed in ember-try...

@ghost
Copy link
Author

ghost commented Jul 20, 2015

Lets give that a try ;)

@rwjblue
Copy link
Member

rwjblue commented Jul 20, 2015

Fixed by #79 #80 and #81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant