Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onerror should not be cached on load #993

Closed
wagenet opened this issue Feb 22, 2021 · 1 comment · Fixed by #994
Closed

onerror should not be cached on load #993

wagenet opened this issue Feb 22, 2021 · 1 comment · Fixed by #994

Comments

@wagenet
Copy link
Member

wagenet commented Feb 22, 2021

Instead, it should be cached the first time setupOnerror is called.

See emberjs/ember-qunit#818.
@rwjblue
Copy link
Member

rwjblue commented Feb 22, 2021

In general, I think its fine to change where we cache it but we definitely need to do it before setupOnerror is called the first time.

We can do it in setupContext.

@rwjblue rwjblue mentioned this issue Feb 22, 2021
Closed
@wagenet wagenet mentioned this issue Feb 23, 2021
Merged
wagenet added a commit to wagenet/ember-test-helpers that referenced this issue Feb 23, 2021
@wagenet
More robust handling in setup-onerror
f32f722 
Resolves an issue where Ember.onerror could get cached too soon.

Fixes emberjs#993
wagenet added a commit to wagenet/ember-test-helpers that referenced this issue Feb 23, 2021
@wagenet
More robust handling in setup-onerror
cd7a54b 
Resolves an issue where Ember.onerror could get cached too soon.

Fixes emberjs#993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make setupOnerror more resilient wagenet/ember-test-helpers
2 participants
@wagenet @rwjblue