Use Application.create().buildInstance() if possible.
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
application-build-instance
branch
from
292335c to
23b62cb
Compare
|
@rwjblue looks like CI is unhappy with this change |
|
Yep! Still WIP for now. I have a few things to do first (updated with checklist in issue description). |
rwjblue
force-pushed
the
application-build-instance
branch
from
23b62cb to
f5ec85a
Compare
rwjblue
force-pushed
the
application-build-instance
branch
from
992d524 to
93fc750
Compare
Handle the "normal" case of building a application instance instance, but if using the older "custom resolver" system just fall back to use the legacy build registry function.
rwjblue
changed the title
Application.create().buildInstance().Application.create().buildInstance().
rwjblue
changed the title
Application.create().buildInstance().Application.create().buildInstance() if possible.
Turbo87
reviewed
Nov 8, 2017
| resolve(fullName) { | ||
| return registry[fullName] || this._super(...arguments); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
is that going to be required for all apps?
There was a problem hiding this comment.
No, absolutely not! This is only a thing needed to test things internally here. Basically the setResolverRegistry test helper function (just here in the tests of this repo) resets the list of "known" modules so that we can test things like this.owner.register "wins" over what is resolved, and whatnot.
No problem, thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host project properly registers their application, the testing context will now boot a lightweight instance of the application (similar to what FastBoot does).
In this scenario both
initializersandinstance-initializerswill run so no more manual initializer setup shenanigans (as documented here fore mirage). This has been a very long standing point of confusion for folks while testing, and I'm very excited to finally have a path forward that is both performant and intuitive.For those curious,
initializerswill run only once for the entire test suite (unlike acceptance tests prior to emberjs/rfcs#268), and theinstance-initializerswill run once per test (which also mirrors how FastBoot works internally).This new system nearly identically matches how real applications work in the wild, and is a much less brittle platform for our continued testing "unification".
Fixes #234