make getApplication public #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Mar 3, 2018
|
Should we have the tests passing before merging this? Took a shot with #341 but may need some help. |
snewcomer
force-pushed
the
get-application-import
branch
from
2e9fbea to
d8fac99
Compare
rwjblue
approved these changes
Mar 19, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One use case I have is I would like to call
setApplication(Application.create({ autoboot: false, custom: 'bar' });or something similar. However, this may be a bit dangerous because this sets the application for the rest of the test run. In order to ensure further calls to get the application instance aren't this Application instance, I need to reset it with the old application instance usingthis.oldAppInstance = getApplication()before setting.Lmk what you think!
Ref #335