Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate to DS._setupContainer when available to register service:store #39

Merged
merged 1 commit into from
Apr 28, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Apr 17, 2015

This pr will automatically register the Store as a service for users running. Ember Data beta.16.

The one gotcha is if the user declares service:store in their needs. For Example:

moduleForComponent('actor-table', {
  // specify the other units that are required for this test
  needs: ['service:store']
});

The test will blow up with this error. Uncaught TypeError: Attempting to register an unknown factory: 'service:store', because this code https://github.com/switchfly/ember-test-helpers/blob/master/lib/ember-test-helpers/isolated-container.js#L81-L85 attempts to pull in a service:store from app/services/store.js which likely doesn't exist.

rwjblue added a commit that referenced this pull request Apr 28, 2015
Delegate to DS._setupContainer when available to register service:store
@rwjblue rwjblue merged commit 835c54b into emberjs:master Apr 28, 2015
@bmac bmac deleted the register-store-service branch April 29, 2015 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants