Implement test helper logging #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 4, 2019
rwjblue
reviewed
Dec 6, 2019
| * Logs a debug message to the console if the `testHelperLogging` query | ||
| * parameter is set. | ||
| * | ||
| * @private |
There was a problem hiding this comment.
FWIW, I wonder if this should actually be private. Seems like it might be nice for folks authoring custom helpers too...
There was a problem hiding this comment.
I'd say let's try it out and see if it works properly before we commit to making it a public API
rwjblue
approved these changes
Dec 6, 2019
|
restarted ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #740
The implementation is roughly similar to miragejs/ember-cli-mirage#1818. I've imported the
elementToString()implementation that qunit-dom is using to describe target elements if they are not passed in as selector strings.