Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose @ember/test-waiters in addition to ember-test-waiters module names #133

Merged
merged 6 commits into from
May 13, 2020
Merged

Expose @ember/test-waiters in addition to ember-test-waiters module names #133

merged 6 commits into from
May 13, 2020

Conversation

scalvert
Copy link
Collaborator

Module rename as part of RFC 0581

@scalvert scalvert requested a review from rwjblue April 20, 2020 16:49
rwjblue
rwjblue requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of inline comments, but can you add a test file that intentionally imports from ember-test-waiters?

addon/ember-test-waiters/index.js Show resolved Hide resolved
addon/@ember/test-waiters/build-waiter.ts Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@scalvert scalvert requested a review from rwjblue April 20, 2020 17:16
@scalvert
Copy link
Collaborator Author

@rwjblue added a sanity check task that imports from ember-test-waiters to ensure the legacy module import works.

@rwjblue
Copy link
Member

rwjblue commented May 7, 2020

@scalvert - Changes seem good, should we also change the package name while we are at it?

@scalvert
Copy link
Collaborator Author

scalvert commented May 7, 2020

Agree. Will add that.

@scalvert scalvert changed the title WIP: Publishing @ember/test-waiters in addition to ember-test-waiters Publishing @ember/test-waiters in addition to ember-test-waiters May 7, 2020
@scalvert scalvert requested a review from rwjblue May 7, 2020 21:20
@scalvert
Copy link
Collaborator Author

scalvert commented May 7, 2020

I removed the deprecation and updated some other references to the old module name. I also extended the highlander check to include the new module name.

Can you take another look, @rwjblue?

@rwjblue rwjblue self-assigned this May 9, 2020
rwjblue
rwjblue reviewed May 13, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@scalvert scalvert force-pushed the scoping-package branch 2 times, most recently from 54813b1 to f0fb342 Compare May 13, 2020 18:32
@rwjblue rwjblue added the enhancement New feature or request label May 13, 2020
@rwjblue rwjblue changed the title Publishing @ember/test-waiters in addition to ember-test-waiters Expose @ember/test-waiters in addition to ember-test-waiters module names May 13, 2020
@scalvert scalvert merged commit b089689 into master May 13, 2020
@scalvert scalvert deleted the scoping-package branch May 13, 2020 18:48
@scalvert scalvert mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees

@rwjblue rwjblue

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scalvert @rwjblue