Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrectly nested exports for users of ember-cli < 3.13.x #165

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

scalvert
Copy link
Collaborator

The current private API usage in treeForAddon would not correctly define multiple top-level modules if a consumer was on ember-cli < 3.13. This PR fixes that issue by utilizing public API.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@scalvert scalvert requested a review from rwjblue July 28, 2020 23:17
@scalvert scalvert added the bug Something isn't working label Jul 28, 2020
@rwjblue rwjblue merged commit 796d26a into master Jul 28, 2020
@rwjblue rwjblue deleted the fix-exports-again branch July 28, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants