Drop support for the 'global' global. Every supported environment has globalThis
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
drop-support-for-global-global
branch
from
7a3cb48 to
afc8233
Compare
SergeAstapov
approved these changes
May 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: I didn't want to figure out how to type
globalas a global, and since only node hasglobal... we don't need to care about its existence (since any js runtime that hasglobalalso hasglobalThis-- which we do support)for node / fastboot,
globalThiswas introduced in Node 12, which we already don't support as it's far beyond LTS support period. Prior to Node 12, this library will no longer work in fastboot mode (so you'd have to usev3.xof test-waiters).