Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests against strictest embroider -- which we weren't doing before.
This is important because in the v2 addon conversion, I ran in to
instanceof
fails in classic mode embroider-build/ember-auto-import#588which is actually good, because test-waiters needs to be resilient to:
Adding embroider to the matrix helps verify that the problem is with auto-import having duplicate test-time dependencies, vs embroider fixing the problem and having only one copy of a dependency.
Why not use the try matrix, like in the blueprint?
pnpm i
isn't enough).