Skip to content

Commit

Permalink
Bugfix: restore publishing of internals entrypoints
Browse files Browse the repository at this point in the history
This is a followup bugfix to #20675.

That PR inadvertently stopped publishing entrypoints for certain internal packages, when consuming ember as separate modules. These packages are not public API, but they're used, so we need to keep them.

A symptom of what breaks here is ember-data importing `@ember/-internals/metal`, when building with Embroider's strictEmberSource option.
  • Loading branch information
ef4 committed May 21, 2024
1 parent 08537e2 commit 417dbc5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,10 @@ function packages() {
});

// add only the entrypoints of the rolledUpPackages
entryFiles = [...entryFiles, ...glob.sync(`{${rolledUpPackages().join(',')}}/index.{js,ts}`)];
entryFiles = [
...entryFiles,
...glob.sync(`{${rolledUpPackages().join(',')}}/index.{js,ts}`, { cwd: 'packages' }),
];

return Object.fromEntries(
entryFiles.map((filename) => [filename.replace(/\.[jt]s$/, ''), filename])
Expand Down

0 comments on commit 417dbc5

Please sign in to comment.