-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Lazy router setup in non-application tests
During non setupApplicationTests type tests, the Router being injected into service:router and service:routing does not setup automatically, during which it initializes its _routerMicrolib, etc. Public API on service:router will throw in those tests. This commit will trigger setupRouter when accessing EmberRouter via router service to avoid those errors.
- Loading branch information
Showing
6 changed files
with
152 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
packages/ember/tests/routing/router_service_test/non_application_test_test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| import { inject as injectService } from '@ember/service'; | ||
| import { Router, NoneLocation } from '@ember/-internals/routing'; | ||
| import { get } from '@ember/-internals/metal'; | ||
| import { run } from '@ember/runloop'; | ||
| import { Component } from '@ember/-internals/glimmer'; | ||
| import { RenderingTestCase, moduleFor } from 'internal-test-helpers'; | ||
|
|
||
| moduleFor( | ||
| 'Router Service - non application test', | ||
| class extends RenderingTestCase { | ||
| constructor() { | ||
| super(...arguments); | ||
|
|
||
| this.resolver.add('router:main', Router.extend(this.routerOptions)); | ||
| this.router.map(function() { | ||
| this.route('parent', { path: '/' }, function() { | ||
| this.route('child'); | ||
| this.route('sister'); | ||
| this.route('brother'); | ||
| }); | ||
| this.route('dynamic', { path: '/dynamic/:dynamic_id' }); | ||
| this.route('dynamicWithChild', { path: '/dynamic-with-child/:dynamic_id' }, function() { | ||
| this.route('child', { path: '/:child_id' }); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| get routerOptions() { | ||
| return { | ||
| location: 'none', | ||
| }; | ||
| } | ||
|
|
||
| get router() { | ||
| return this.owner.resolveRegistration('router:main'); | ||
| } | ||
|
|
||
| get routerService() { | ||
| return this.owner.lookup('service:router'); | ||
| } | ||
|
|
||
| afterEach() { | ||
| super.afterEach(); | ||
| } | ||
|
|
||
| ['@test RouterService can be instantiated in non application test'](assert) { | ||
| assert.ok(this.routerService); | ||
| } | ||
|
|
||
| ['@test RouterService properties can be accessed with default'](assert) { | ||
| assert.expect(5); | ||
| assert.equal(this.routerService.get('currentRouteName'), null); | ||
| assert.equal(this.routerService.get('currentURL'), null); | ||
| assert.ok(this.routerService.get('location') instanceof NoneLocation); | ||
| assert.equal(this.routerService.get('rootURL'), '/'); | ||
| assert.equal(this.routerService.get('currentRoute'), null); | ||
| } | ||
|
|
||
| ['@test RouterService#urlFor returns url'](assert) { | ||
| assert.equal(this.routerService.urlFor('parent.child'), '/child'); | ||
| } | ||
|
|
||
| ['@test RouterService#transitionTo with basic route'](assert) { | ||
| assert.expect(2); | ||
|
|
||
| let componentInstance; | ||
|
|
||
| this.addTemplate('parent.index', '{{foo-bar}}'); | ||
|
|
||
| this.addComponent('foo-bar', { | ||
| ComponentClass: Component.extend({ | ||
| routerService: injectService('router'), | ||
| init() { | ||
| this._super(...arguments); | ||
| componentInstance = this; | ||
| }, | ||
| actions: { | ||
| transitionToSister() { | ||
| get(this, 'routerService').transitionTo('parent.sister'); | ||
| }, | ||
| }, | ||
| }), | ||
| template: `foo-bar`, | ||
| }); | ||
|
|
||
| this.render('{{foo-bar}}'); | ||
|
|
||
| run(function() { | ||
| componentInstance.send('transitionToSister'); | ||
| }); | ||
|
|
||
| assert.equal(this.routerService.get('currentRouteName'), 'parent.sister'); | ||
| assert.ok(this.routerService.isActive('parent.sister')); | ||
| } | ||
|
|
||
| ['@test RouterService#recognize recognize returns routeInfo'](assert) { | ||
| let routeInfo = this.routerService.recognize('/dynamic-with-child/123/1?a=b'); | ||
| assert.ok(routeInfo); | ||
| let { name, localName, parent, child, params, queryParams, paramNames } = routeInfo; | ||
| assert.equal(name, 'dynamicWithChild.child'); | ||
| assert.equal(localName, 'child'); | ||
| assert.ok(parent); | ||
| assert.equal(parent.name, 'dynamicWithChild'); | ||
| assert.notOk(child); | ||
| assert.deepEqual(params, { child_id: '1' }); | ||
| assert.deepEqual(queryParams, { a: 'b' }); | ||
| assert.deepEqual(paramNames, ['child_id']); | ||
| } | ||
| } | ||
| ); |